Issue 12474007: Revert 20127

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12474007: Revert 20127 (Closed)

Created:
7 years, 9 months ago by Emily Fortuna

Modified:
7 years, 9 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert 20127 TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=20133

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -467 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	17 chunks	+72 lines, -160 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	15 chunks	+46 lines, -120 lines	0 comments	Download
M	tests/html/fileapi_test.dart	View	4 chunks	+17 lines, -11 lines	0 comments	Download
M	tests/html/notifications_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	tools/dom/templates/html/dart2js/impl_Notification.darttemplate	View	1 chunk	+7 lines, -5 lines	0 comments	Download
A	tools/dom/templates/html/dart2js/impl_WorkerContext.darttemplate	View	1 chunk	+24 lines, -0 lines	0 comments	Download
D	tools/dom/templates/html/impl/impl_DirectoryEntry.darttemplate	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	tools/dom/templates/html/impl/impl_EventSource.darttemplate	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_MutationObserver.darttemplate	View	2 chunks	+15 lines, -1 line	0 comments	Download
D	tools/dom/templates/html/impl/impl_Notification.darttemplate	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	tools/dom/templates/html/impl/impl_WorkerContext.darttemplate	View	1 chunk	+0 lines, -57 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Committed patchset #1 manually as r20133 (presubmit successful).

7 years, 9 months ago (2013-03-16 00:14:41 UTC) #1

Emily Fortuna

TBR. I can't get this to fail locally for some reason...

7 years, 9 months ago (2013-03-16 00:15:20 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages