Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1247333003: dart2js cps: Support 'on T' clauses without a 'catch'. (Closed)

Created:
5 years, 5 months ago by asgerf
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Support 'on T' clauses without a 'catch'. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/7d8067135cd30352ff3b713e70d6249d69295691

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -41 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -28 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 5 months ago (2015-07-22 14:36:28 UTC) #2
karlklose
LGTM!
5 years, 5 months ago (2015-07-23 08:22:52 UTC) #3
asgerf
5 years, 5 months ago (2015-07-23 10:39:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7d8067135cd30352ff3b713e70d6249d69295691 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698