Issue 12473002: Complete implementation of bounds checking in the vm, by introducing a vm object

Issue 12473002: Complete implementation of bounds checking in the vm, by introducing a vm object (Closed)

Created:
7 years, 9 months ago by regis

Modified:
7 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, hausner, Ivan Posva, siva, zra

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Complete implementation of bounds checking in the vm, by introducing a vm object BoundedType that represents a type that could not be checked against an upper bound at compile time. A BoundedType is verified at run time when used, typically when it (and/or its bound) gets instantiated. This fixes issues 7075 and 7625. Added one test. Committed: https://code.google.com/p/dart/source/detail?r=19519

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+773 lines, -300 lines)			Patch
M	runtime/vm/class_finalizer.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/vm/class_finalizer.cc	View		21 chunks	+157 lines, -60 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View		8 chunks	+25 lines, -21 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		2 chunks	+6 lines, -7 lines	0 comments	Download
M	runtime/vm/heap_profiler.cc	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2	11 chunks	+96 lines, -14 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	31 chunks	+341 lines, -153 lines	0 comments	Download
M	runtime/vm/object_store.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View		3 chunks	+10 lines, -5 lines	0 comments	Download
M	runtime/vm/raw_object.h	View		3 chunks	+19 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View		5 chunks	+63 lines, -31 lines	0 comments	Download
M	runtime/vm/snapshot.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/type_variable_bounds3_test.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/12473002/diff/8001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/12473002/diff/8001/runtime/vm/object.h#newcode3734 runtime/vm/object.h:3734: HEAP_OBJECT_IMPLEMENTATION(BoundedType, AbstractType); FINAL_HEAP_ ...

7 years, 9 months ago (2013-03-05 21:53:15 UTC) #2

regis

Thanks! https://codereview.chromium.org/12473002/diff/8001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/12473002/diff/8001/runtime/vm/object.h#newcode3734 runtime/vm/object.h:3734: HEAP_OBJECT_IMPLEMENTATION(BoundedType, AbstractType); On 2013/03/05 21:53:16, srdjan wrote: > ...

7 years, 9 months ago (2013-03-05 21:59:58 UTC) #3

regis

7 years, 9 months ago (2013-03-05 22:04:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19519 (presubmit successful).

Expand Messages | Collapse Messages