Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1246983003: dart2js: add failing test for namer and global stubs. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org, herhut
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: add failing test for namer and global stubs. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/11a0f292a37c20a7137b9875ddaa476832c09a7a

Patch Set 1 #

Patch Set 2 : Update comment. #

Patch Set 3 : More comment-update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5465 lines, -0 lines) Patch
A tests/language/classes_static_method_clash_test.dart View 1 2 1 chunk +5464 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 5 months ago (2015-07-21 17:27:15 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 5 months ago (2015-07-21 20:12:07 UTC) #3
floitsch
5 years, 5 months ago (2015-07-21 20:47:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
11a0f292a37c20a7137b9875ddaa476832c09a7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698