Issue 1246823002: Fix build:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1246823002: Fix build: (Closed)

Created:
5 years, 5 months ago by Ivan Posva

Modified:
5 years, 5 months ago

Reviewers:
Bill Hesse, floitsch

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix build: - Mark isolate tests with newly added parameters failing on dart2js. - Specify files needed to be supplied to test harness for spawnUri. BUG= Committed: https://github.com/dart-lang/sdk/commit/fb4a42279bffcf9cddbd13aead07e31a453cd0a4

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -1 line)			Patch
M	tests/isolate/error_at_spawnuri_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/isolate/error_exit_at_spawnuri_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/isolate/exit_at_spawnuri_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/isolate/isolate.status	View	2 chunks	+8 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Ivan Posva

Committed patchset #1 (id:1) manually as fb4a42279bffcf9cddbd13aead07e31a453cd0a4 (presubmit successful).

5 years, 5 months ago (2015-07-20 22:00:25 UTC) #3

Message was sent while issue was closed.

LGTM.