Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1246713005: Fix a Debian build error. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a Debian build error. It turns out it's not safe to assume that pub is checked out from Git when running from the SDK repo. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/8abe19766853ad58c4c107a73678e2bccfeb1d4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M lib/src/command_runner.dart View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 5 months ago (2015-07-20 21:30:00 UTC) #1
Bob Nystrom
lgtm
5 years, 5 months ago (2015-07-20 21:43:31 UTC) #2
nweiz
5 years, 5 months ago (2015-07-20 21:47:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8abe19766853ad58c4c107a73678e2bccfeb1d4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698