Improve error messages for invalid requests

Improve error messages for invalid requests

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/15a0f755e8ff461f3bb9c3d13f799055a2d8e37f

[Brian Wilkerson, 2015-07-19 16:41:25]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-07-19 23:00:05]

lgtm

https://codereview.chromium.org/1246573002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/1246573002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol.dart:304: throw mismatch(jsonPath, 'bool',
json.toString());
Consider using JSON.encode(json) rather than json.toString(), since
JSON.encode() will format things unambiguously (e.g. [1, '2'].toString() == '[1,
2]' whereas JSON.encode([1, '2']) == '[1,"2"]').

Also, consider changing the new argument to "mismatch" to an Object and letting
mismatch() handle string conversion, just so that all the string conversion code
is in one place.

[Brian Wilkerson, 2015-07-20 16:32:47]

PTAL

https://codereview.chromium.org/1246573002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/1246573002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol.dart:304: throw mismatch(jsonPath, 'bool',
json.toString());
Done

[Paul Berry, 2015-07-20 17:12:21]

lgtm

[Brian Wilkerson, 2015-07-20 17:23:06]

Committed patchset #2 (id:20001) manually as
15a0f755e8ff461f3bb9c3d13f799055a2d8e37f (presubmit successful).