Expanding WebSocket test

Expanding WebSocket test

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=20797

[blois, 2013-03-18 22:07:20]

Was investigating a WebSocket bug report, flushed out the test to echo off of
the server.

[Emily Fortuna, 2013-03-18 22:44:22]

lgtm

https://codereview.chromium.org/12465018/diff/1/tools/testing/dart/http_serve...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/12465018/diff/1/tools/testing/dart/http_serve...
tools/testing/dart/http_server.dart:8: import 'dart:crypto';
I don't see where this import is used.

[blois, 2013-03-18 23:04:48]

https://codereview.chromium.org/12465018/diff/1/tools/testing/dart/http_serve...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/12465018/diff/1/tools/testing/dart/http_serve...
tools/testing/dart/http_server.dart:8: import 'dart:crypto';
On 2013/03/18 22:44:22, Emily Fortuna wrote:
> I don't see where this import is used.

Remnant from before I noticed the WebSocketTransformer class.

[kustermann, 2013-03-19 12:13:43]

lgtm

https://codereview.chromium.org/12465018/diff/3002/tools/testing/dart/http_se...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/12465018/diff/3002/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:135: } else if (request.uri.path == '/ws') {
Please add '/ws' to the description of the http server on line 19.

[Søren Gjesse, 2013-03-19 12:31:12]

dbc

https://codereview.chromium.org/12465018/diff/3002/tools/testing/dart/http_se...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/12465018/diff/3002/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:192:
WebSocketTransformer.upgrade(request).then((websocket) {
There should be a catchError (with some print statement) on this upgrade
otherwise an uncaught error can cause the HTTP server to terminate during
testing.

https://codereview.chromium.org/12465018/diff/3002/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:195: websocket.close();
There should also be an onError handler here to avoid uncaught errors in the
HTTP server.

[blois, 2013-03-20 21:05:17]

https://codereview.chromium.org/12465018/diff/3002/tools/testing/dart/http_se...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/12465018/diff/3002/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:135: } else if (request.uri.path == '/ws') {
On 2013/03/19 12:13:43, kustermann wrote:
> Please add '/ws' to the description of the http server on line 19.

Done.

https://codereview.chromium.org/12465018/diff/3002/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:192:
WebSocketTransformer.upgrade(request).then((websocket) {
On 2013/03/19 12:31:13, Søren Gjesse wrote:
> There should be a catchError (with some print statement) on this upgrade
> otherwise an uncaught error can cause the HTTP server to terminate during
> testing.

Done.

https://codereview.chromium.org/12465018/diff/3002/tools/testing/dart/http_se...
tools/testing/dart/http_server.dart:195: websocket.close();
On 2013/03/19 12:31:13, Søren Gjesse wrote:
> There should also be an onError handler here to avoid uncaught errors in the
> HTTP server.

Done.

[Søren Gjesse, 2013-04-02 07:48:10]

lgtm

[blois, 2013-04-02 16:45:16]

Committed patchset #3 manually as r20797 (presubmit successful).