Add a test and improve comment on generic checks.

Add a test and improve comment on generic checks.
Committed: https://code.google.com/p/dart/source/detail?r=19557

[karlklose, 2013-03-06 09:14:54]

LGTM.

https://codereview.chromium.org/12463012/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/12463012/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:551: DartType
receiverType = expressionType.computeType(compiler);
Please change this to use 'rawType', so it matches with the comment.

https://codereview.chromium.org/12463012/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:555:
compiler.types.isSubtype(receiverType, type)) {
Perhaps add a comment that we should not use DartTypes here at all?

[ngeoffray, 2013-03-06 11:43:48]

Thanks Karl.

https://codereview.chromium.org/12463012/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/12463012/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:551: DartType
receiverType = expressionType.computeType(compiler);
On 2013/03/06 09:14:54, karlklose wrote:
> Please change this to use 'rawType', so it matches with the comment.

Done.

https://codereview.chromium.org/12463012/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:555:
compiler.types.isSubtype(receiverType, type)) {
On 2013/03/06 09:14:54, karlklose wrote:
> Perhaps add a comment that we should not use DartTypes here at all?

Added a TODO.

[ngeoffray, 2013-03-06 13:22:08]

Committed patchset #4 manually as r19557 (presubmit successful).