Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1246073005: Retaining path improvements. (Closed)

Created:
5 years, 5 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Retaining path improvements. - Don't answer retaining paths that go through ICData. - Associate edge labels with the referer instead of the referent. - Give edge labels for VM classes (offsets only). - Make is possible to distinguish closures and functions from their refs. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8c98455ab50caf0423bf0c5daae35e24253fd7d4

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -29 lines) Patch
M runtime/observatory/lib/src/elements/inbound_reference.html View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.html View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.html View 2 chunks +7 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/get_retaining_path_rpc_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object_graph.cc View 1 chunk +17 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rmacnak
5 years, 5 months ago (2015-07-23 23:17:05 UTC) #2
Cutch
https://codereview.chromium.org/1246073005/diff/1/runtime/observatory/lib/src/elements/code_ref.dart File runtime/observatory/lib/src/elements/code_ref.dart (left): https://codereview.chromium.org/1246073005/diff/1/runtime/observatory/lib/src/elements/code_ref.dart#oldcode21 runtime/observatory/lib/src/elements/code_ref.dart:21: This needs to stay as code.
5 years, 4 months ago (2015-07-28 21:36:16 UTC) #3
Cutch
LGTM after undoing the code-ref part of the change.
5 years, 4 months ago (2015-07-28 21:39:56 UTC) #4
rmacnak
https://codereview.chromium.org/1246073005/diff/1/runtime/observatory/lib/src/elements/code_ref.dart File runtime/observatory/lib/src/elements/code_ref.dart (left): https://codereview.chromium.org/1246073005/diff/1/runtime/observatory/lib/src/elements/code_ref.dart#oldcode21 runtime/observatory/lib/src/elements/code_ref.dart:21: On 2015/07/28 21:36:16, Cutch wrote: > This needs to ...
5 years, 4 months ago (2015-07-28 22:54:06 UTC) #5
rmacnak
5 years, 4 months ago (2015-07-28 22:56:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8c98455ab50caf0423bf0c5daae35e24253fd7d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698