pkg/unittest: fixed references to configuration implementations

pkg/unittest: fixed references to configuration implementations

Removed references to removed config libraries.
Replaced with references to existing config libraries
Tightened up description of matcher library

Committed: https://code.google.com/p/dart/source/detail?r=19741

[gram, 2013-03-05 18:00:10]

lgtm

lgtm with one small change.

https://codereview.chromium.org/12458002/diff/1/pkg/unittest/lib/unittest.dart
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/12458002/diff/1/pkg/unittest/lib/unittest.dar...
pkg/unittest/lib/unittest.dart:29: *    tests compiled to Javascript in a
browser), and
While we're at it, we should probably change this comment to say that
html_config.dart is "for running tests in a browser"; they don't have to be
compiled to JS.

[kevmoo-old, 2013-03-05 18:25:12]

PTAL

Instead of documenting the other libraries here, I figured it'd be more
maintainable to tell the user were to look for them and they can read the
in-line docs.

See the new output:
http://cl.ly/image/0j240A17420O

[kevmoo-old, 2013-03-05 18:26:12]

...I am left wondering why links to methods and types in the matchers library
are not generated.

[kevmoo-old, 2013-03-05 18:34:15]

While I was at it, fixed up links in matcher docs and removed pub tutorial from
unittest docs

[gram, 2013-03-05 18:52:40]

On 2013/03/05 18:26:12, kevmoo wrote:
> ...I am left wondering why links to methods and types in the matchers library
> are not generated.

That I think is an issue with the doc generator. I thought Andrei had hacked
around that by having some additional imports (check for TODO(andrei)).

[gram, 2013-03-05 18:55:33]

Siggy, do you have an opinion on my latest comments?

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/matcher....
File pkg/unittest/lib/matcher.dart (left):

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/matcher....
pkg/unittest/lib/matcher.dart:6: * inspiration from [Hamcrest] and Ladislav
Thon's [dart-matchers]
I think we want to keep the reference to dart-matchers, unless Ladislav has
retired that. He deserves some credit for us starting the matcher library.

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/unittest...
File pkg/unittest/lib/unittest.dart (left):

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/unittest...
pkg/unittest/lib/unittest.dart:18: * for more details about the pub package
manager.
I think we may want to keep this. Siggy, what do you think?

[kevmoo-old, 2013-03-05 20:21:08]

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/matcher....
File pkg/unittest/lib/matcher.dart (left):

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/matcher....
pkg/unittest/lib/matcher.dart:6: * inspiration from [Hamcrest] and Ladislav
Thon's [dart-matchers]
dart-matchers is no longer alive, it appears. Link is dead.

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/unittest...
File pkg/unittest/lib/unittest.dart (left):

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/unittest...
pkg/unittest/lib/unittest.dart:18: * for more details about the pub package
manager.
Then should all pkg libraries have the pub instructions? Seems like something
that should be standardized and not special to unittest.

Even the description is a bit outdated since most folks will be using the Dart
editor to edit their pubspec file, right?

[kevmoo-old, 2013-03-06 19:56:10]

I'm happy to break out the pub tweaks just to get the doc header into a better
state.

Although I think all of these changes okay.

[Siggi Cherem (dart-lang), 2013-03-07 19:34:54]

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/unittest...
File pkg/unittest/lib/unittest.dart (left):

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/unittest...
pkg/unittest/lib/unittest.dart:18: * for more details about the pub package
manager.
On 2013/03/05 20:21:08, kevmoo wrote:
> Then should all pkg libraries have the pub instructions? Seems like something
> that should be standardized and not special to unittest.

So and so. Many of our users might not come to Dart and get started with pub
right away. It's hard to tell when they'll start using pub, but I believe that
for many developers 'unittest' is likely to be the first package from 'pkg'
they'll install with pub. That's why I lean towards making this package a bit
more informative about this than the rest.

> 
> Even the description is a bit outdated since most folks will be using the Dart
> editor to edit their pubspec file, right?

We could rephrase things. It doesn't need to be too versbose, maybe just
combining the first and last sentence of this whole section might be enough:

"To import this library, install the [unittest
package](http://pub.dartlang.org/packages/unittest) via the pub package manager.
Please see [Pub Getting Started](http://pub.dartlang.org/doc) for more details."

I don't think we need to mention anything about how you edit your pubspec files,
let's just have the pub documentation deal with that.

[kevmoo-old, 2013-03-07 20:35:30]

PTAL

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/matcher....
File pkg/unittest/lib/matcher.dart (left):

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/matcher....
pkg/unittest/lib/matcher.dart:6: * inspiration from [Hamcrest] and Ladislav
Thon's [dart-matchers]
On 2013/03/05 18:55:33, gram wrote:
> I think we want to keep the reference to dart-matchers, unless Ladislav has
> retired that. He deserves some credit for us starting the matcher library.

Done.

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/unittest...
File pkg/unittest/lib/unittest.dart (left):

https://codereview.chromium.org/12458002/diff/11001/pkg/unittest/lib/unittest...
pkg/unittest/lib/unittest.dart:18: * for more details about the pub package
manager.
Understood. On it.

[gram, 2013-03-07 20:42:24]

lgtm

[kevmoo-old, 2013-03-07 20:43:43]

I lack the bit. Please commit.

...and if any of you have sway with granting committer's privileges...

Thanks

[kevmoo-old, 2013-03-08 22:40:32]

Committed patchset #5 manually as r19741 (presubmit successful).