Issue 12457037: Marked basic_debuger_test as Timeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12457037: Marked basic_debuger_test as Timeout (Closed)

Created:
7 years, 9 months ago by kustermann

Modified:
7 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Drain stdin in basic_debuger_test and did status file update Committed: https://code.google.com/p/dart/source/detail?r=20523

Patch Set 2 : Drain stdin #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	tests/standalone/debugger/debug_lib.dart	View	1	1 chunk	+1 line, -0 lines	1 comment	Download
	M	tests/standalone/standalone.status	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/12457037/diff/5001/tests/standalone/debugger/debug_lib.dart File tests/standalone/debugger/debug_lib.dart (right): https://codereview.chromium.org/12457037/diff/5001/tests/standalone/debugger/debug_lib.dart#newcode327 tests/standalone/debugger/debug_lib.dart:327: stdin.listen((_) {}); OK?

7 years, 9 months ago (2013-03-26 16:49:40 UTC) #2

kustermann

7 years, 9 months ago (2013-03-26 16:54:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20523 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12457037: Marked basic_debuger_test as Timeout (Closed)

Description

Patch Set 1 #

Patch Set 2 : Drain stdin #

Messages