Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1245513002: Refactor AnalysisOptionsProvider (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M pkg/analyzer/lib/source/analysis_options_provider.dart View 1 2 chunks +19 lines, -6 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 5 months ago (2015-07-17 22:12:18 UTC) #2
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-17 22:16:36 UTC) #3
Cutch
5 years, 5 months ago (2015-07-17 22:17:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
977d2133449b53db1e4d600ba0855c260282d53c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698