Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 12455012: Fix the handling of screen orientation changes. In these cases almost the entire application is tor… (Closed)

Created:
7 years, 9 months ago by gram
Modified:
7 years, 9 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the handling of screen orientation changes. In these cases almost the entire application is torn down, which includes the destruction of the VMGlue instance. When we restart we create a new VMGlue but we don't want to reinitialize the VM, just create a new main isolate. Also in the CL, I added a dependency of the .apk on the embedder library, so that I can rebuild the apk after a library change without having to start from scratch. Committed: https://code.google.com/p/dart/source/detail?r=19510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M runtime/embedders/openglui/common/vm_glue.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/embedders/openglui/common/vm_glue.cc View 2 chunks +1 line, -1 line 0 comments Download
M samples/openglui/android/AndroidManifest.xml View 1 chunk +1 line, -3 lines 0 comments Download
M samples/openglui/android/android.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 9 months ago (2013-03-05 19:44:48 UTC) #1
vsm
lgtm
7 years, 9 months ago (2013-03-05 19:46:58 UTC) #2
gram
7 years, 9 months ago (2013-03-05 19:50:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698