Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 12450026: Added tools/bots/editor.py to build the editor (using gyp/build.py) and run editor tests (Closed)

Created:
7 years, 9 months ago by kustermann
Modified:
7 years, 9 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added tools/bots/editor.py to build the editor (using gyp/build.py) and run editor tests Committed: https://code.google.com/p/dart/source/detail?r=20319

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -11 lines) Patch
M client/tools/buildbot_annotated_steps.py View 4 chunks +13 lines, -11 lines 0 comments Download
M tools/bots/bot.py View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/bots/editor.py View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 9 months ago (2013-03-21 14:41:17 UTC) #1
ricow1
LGTM I think we should move the testing into the testing scripts - but let ...
7 years, 9 months ago (2013-03-21 15:13:05 UTC) #2
kustermann
https://codereview.chromium.org/12450026/diff/1/tools/bots/editor.py File tools/bots/editor.py (right): https://codereview.chromium.org/12450026/diff/1/tools/bots/editor.py#newcode2 tools/bots/editor.py:2: On 2013/03/21 15:13:05, ricow1 wrote: > remove blank line ...
7 years, 9 months ago (2013-03-21 15:24:48 UTC) #3
kustermann
7 years, 9 months ago (2013-03-21 15:25:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698