Automatically step past async state-machine switch for 'anext'.

Automatically step past async state-machine switch for 'anext'.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/f26050ce08ac91db0865134d50f0fc9e9a02fec5

[rmacnak, 2015-07-20 23:02:57]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-07-20 23:49:35]

LGTM w/ comments

https://codereview.chromium.org/1244983002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1244983002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1402: /// result[1] completes
after the second resume. Tests should wait on this
name these constants, e.g.:
result[0] -> result[kFirstResume]
result[1] -> result[kSecondResume]

https://codereview.chromium.org/1244983002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1442: }
else { assert(onResume == firstResume); } ?

https://codereview.chromium.org/1244983002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1447:
this.resume().catchError(handleError);
You use isolate. above, please be consistent with 'this' or 'isolate'

[rmacnak, 2015-07-21 17:35:36]

https://codereview.chromium.org/1244983002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1244983002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1402: /// result[1] completes
after the second resume. Tests should wait on this
On 2015/07/20 23:49:35, Cutch wrote:
> name these constants, e.g.:
> result[0] -> result[kFirstResume]
> result[1] -> result[kSecondResume]

Done.

https://codereview.chromium.org/1244983002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1442: }
On 2015/07/20 23:49:35, Cutch wrote:
> else { assert(onResume == firstResume); } ?

Switching to
              if (onResume != null) {
                onResume.complete(this);
                onResume = null;
              }

onResume may be null if we break and resume somewhere else before returning to
the async continutation.

https://codereview.chromium.org/1244983002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1447:
this.resume().catchError(handleError);
On 2015/07/20 23:49:35, Cutch wrote:
> You use isolate. above, please be consistent with 'this' or 'isolate'

Done.

[rmacnak, 2015-07-21 17:36:05]

Committed patchset #3 (id:40001) manually as
f26050ce08ac91db0865134d50f0fc9e9a02fec5 (presubmit successful).