Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 12449016: Use ".."-style imports in scheduled_test. (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, Alan Knight
Visibility:
Public.

Description

Use ".."-style imports in scheduled_test. This will allow it to be imported by Pub, and to import pkg/http for future tests. Committed: https://code.google.com/p/dart/source/detail?r=19905

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M pkg/scheduled_test/lib/descriptor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/scheduled_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/directory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/file.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/nothing.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
pkg/scheduled_test/lib/src/schedule.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/descriptor_test.dart View 1 chunk +3 lines, -3 lines 2 comments Download
M pkg/scheduled_test/test/metatest.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_process_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_test_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/test/substitute_future_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/test/utils.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/scheduled_test/test/value_future_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
ccing Alan because he's writing tests that use this, and this will break them if ...
7 years, 9 months ago (2013-03-12 22:20:24 UTC) #1
Bob Nystrom
One sugg-question, but LGTM either way. https://codereview.chromium.org/12449016/diff/1/pkg/scheduled_test/test/descriptor_test.dart File pkg/scheduled_test/test/descriptor_test.dart (right): https://codereview.chromium.org/12449016/diff/1/pkg/scheduled_test/test/descriptor_test.dart#newcode12 pkg/scheduled_test/test/descriptor_test.dart:12: import '../lib/scheduled_test.dart'; These ...
7 years, 9 months ago (2013-03-12 22:23:35 UTC) #2
nweiz
https://codereview.chromium.org/12449016/diff/1/pkg/scheduled_test/test/descriptor_test.dart File pkg/scheduled_test/test/descriptor_test.dart (right): https://codereview.chromium.org/12449016/diff/1/pkg/scheduled_test/test/descriptor_test.dart#newcode12 pkg/scheduled_test/test/descriptor_test.dart:12: import '../lib/scheduled_test.dart'; On 2013/03/12 22:23:35, Bob Nystrom wrote: > ...
7 years, 9 months ago (2013-03-12 22:43:46 UTC) #3
nweiz
7 years, 9 months ago (2013-03-12 23:57:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19905 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698