Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 12448006: Lots of little changes for dartdoc/apidoc. (Closed)

Created:
7 years, 9 months ago by Andrei Mouravski
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Lots of little changes for dartdoc/apidoc. * Alphabetized imports. * Added TODOs. * Removed some prefixes. * Cleaned up a LOT of async code to make it work better. * Much, much, much friendlier status messages for dartdoc/apidoc. More to do... * Prevented many, many bad warnings from showing up... by fixing them. * Smarter finding of packages directories. * Started using pathos all over the place. * Added indexed_db to html_diff. Committed: https://code.google.com/p/dart/source/detail?r=19817

Patch Set 1 #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -165 lines) Patch
M pkg/webdriver/lib/webdriver.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/bin/dartdoc.dart View 1 2 3 chunks +26 lines, -27 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 2 5 chunks +60 lines, -25 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/universe_serializer.dart View 1 10 chunks +34 lines, -22 lines 0 comments Download
M sdk/lib/_internal/dartdoc/test/dartdoc_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/apidoc.dart View 10 chunks +74 lines, -84 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M utils/apidoc/html_diff.dart View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Andrei Mouravski
And this was all in the process of finding some other bugs. Yay! Nicer looking ...
7 years, 9 months ago (2013-03-08 02:14:12 UTC) #1
Jacob
https://codereview.chromium.org/12448006/diff/3001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/12448006/diff/3001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode299 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:299: * Will print whether dartdoc is running, whether dartdoc ...
7 years, 9 months ago (2013-03-11 19:05:09 UTC) #2
Andrei Mouravski
PTAL. https://codereview.chromium.org/12448006/diff/3001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/12448006/diff/3001/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode299 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:299: * Will print whether dartdoc is running, whether ...
7 years, 9 months ago (2013-03-11 19:36:46 UTC) #3
Jacob
lgtm
7 years, 9 months ago (2013-03-11 20:00:46 UTC) #4
Andrei Mouravski
7 years, 9 months ago (2013-03-11 20:28:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r19817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698