Support full dart2js output for dartdoc/apidoc.

Support full dart2js output for dartdoc/apidoc.

Committed: https://code.google.com/p/dart/source/detail?r=19537

[ahe, 2013-03-05 14:48:31]

LGTM!

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
(right):

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:202: * has
been successfully compiled.
Add TODO and explain this deprecated but here to support Path which are uses
throughout dartdoc.

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:245:
options = new List<String>.from(options, growable: true);
SIGH!!!

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:266:
Completer<MirrorSystem> result = new Completer<MirrorSystem>();
I think you can use "new Future.immediate" and "new Future.immediateError" here.

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/bin...
File sdk/lib/_internal/dartdoc/bin/dartdoc.dart (right):

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/bin...
sdk/lib/_internal/dartdoc/bin/dartdoc.dart:229: '${dartdoc.totalTypes} types,
and ${dartdoc.totalMembers} members.');
Long line.

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/lib...
File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/dartdoc.dart:136: dartPath, libPath, options:
const <String>['--categories=Client,Server']);
Is the --categories option needed here?

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/dartdoc.dart:379: Path libPath, Path pkgPath) {
Indentation.

[Johnni Winther, 2013-03-06 08:13:11]

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
(right):

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:202: * has
been successfully compiled.
On 2013/03/05 14:48:31, ahe wrote:
> Add TODO and explain this deprecated but here to support Path which are uses
> throughout dartdoc.

Done.

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:245:
options = new List<String>.from(options, growable: true);
On 2013/03/05 14:48:31, ahe wrote:
> SIGH!!!

Done.

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:266:
Completer<MirrorSystem> result = new Completer<MirrorSystem>();
On 2013/03/05 14:48:31, ahe wrote:
> I think you can use "new Future.immediate" and "new Future.immediateError"
here.

Done.

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/bin...
File sdk/lib/_internal/dartdoc/bin/dartdoc.dart (right):

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/bin...
sdk/lib/_internal/dartdoc/bin/dartdoc.dart:229: '${dartdoc.totalTypes} types,
and ${dartdoc.totalMembers} members.');
On 2013/03/05 14:48:31, ahe wrote:
> Long line.

Done.

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/lib...
File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/dartdoc.dart:136: dartPath, libPath, options:
const <String>['--categories=Client,Server']);
On 2013/03/05 14:48:31, ahe wrote:
> Is the --categories option needed here?

Yes. It also finds 'ssa/tracer.dart'. Will investigate later.

https://codereview.chromium.org/12446003/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/dartdoc.dart:379: Path libPath, Path pkgPath) {
On 2013/03/05 14:48:31, ahe wrote:
> Indentation.

Done.

[Johnni Winther, 2013-03-06 08:44:02]

Committed patchset #4 manually as r19537 (presubmit successful).