Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 12445004: Fix simple type inferrer regression by using typeOf instead of returnTypeOf for final fields. (Closed)

Created:
7 years, 9 months ago by ngeoffray
Modified:
7 years, 9 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixsimple type inferrer regression by using typeOf instead of returnTypeOf for final fields. Committed: https://code.google.com/p/dart/source/detail?r=19484

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 5 chunks +6 lines, -5 lines 0 comments Download
A tests/compiler/dart2js/simple_inferrer_final_field_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 9 months ago (2013-03-05 14:19:51 UTC) #1
kasperl
LGTM.
7 years, 9 months ago (2013-03-05 14:32:00 UTC) #2
ngeoffray
7 years, 9 months ago (2013-03-05 14:48:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19484 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698