Issue 12443005: Add superclasses, subclasses, and subtypes tracking to the world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12443005: Add superclasses, subclasses, and subtypes tracking to the world. (Closed)

Created:
7 years, 9 months ago by kasperl

Modified:
7 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add superclasses, subclasses, and subtypes tracking to the world. Add support for computing unions of disjoint types by finding a common supertype or superclass. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19485

Patch Set 1 #

Patch Set 2 : Fix long lines. #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -99 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/types/type_mask.dart	View		3 chunks	+53 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/world.dart	View		3 chunks	+43 lines, -8 lines	1 comment	Download
M	tests/compiler/dart2js/field_type_inferer_test.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/type_combination_test.dart	View	1	3 chunks	+54 lines, -84 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/12443005/diff/6/sdk/lib/_internal/compiler/implementation/world.dart File sdk/lib/_internal/compiler/implementation/world.dart (right): https://codereview.chromium.org/12443005/diff/6/sdk/lib/_internal/compiler/implementation/world.dart#newcode135 sdk/lib/_internal/compiler/implementation/world.dart:135: Iterable<ClassElement> commonSupertypesOf(ClassElement x, ClassElement y) { Please add ...

7 years, 9 months ago (2013-03-05 15:05:50 UTC) #2

kasperl

7 years, 9 months ago (2013-03-05 15:08:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19485 (presubmit successful).

Expand Messages | Collapse Messages