Issue 12441003: Rename String.concat to operator+.

Issue 12441003: Rename String.concat to operator+. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch, srdjan, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename String.concat to operator+. Committed: https://code.google.com/p/dart/source/detail?r=19788

Patch Set 2 : Address comments. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -62 lines)			Patch
M	pkg/intl/lib/bidi_formatter.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/intl/lib/src/date_format_field.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/invocation_mirror_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/string_base.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/tests/vm/dart/inline_stack_frame_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/swarm/swarm_ui_lib/touch/FxUtil.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_string.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree/dartstring.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/core/string.dart	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/io/string_transformer.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js_extra/bailout_test.dart	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/compiler/dart2js_extra/to_string_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/collection_length_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/corelib/string_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/language/constructor2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/constructor3_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/constructor4_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/constructor7_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/constructor_named_arguments_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/example_constructor_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/super_field_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/language/type_guard_conversion_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/debugger/debug_lib.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/file_invalid_arguments_test.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View	1	14 chunks	+14 lines, -14 lines	0 comments	Download
M	tests/standalone/io/pipe_server_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/process_working_directory_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/stream_pipe_test.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/standalone/package/packages/lib1.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/package/packages/lib2/lib2.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/package/packages/lib3/sub/lib3.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/ddbg.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

CL with only String.+ change. Does not make "x"+"x" a compile-time constant.

7 years, 9 months ago (2013-03-05 15:20:08 UTC) #1

Lasse Reichstein Nielsen

(for initial comments only, will require more review before commit).

7 years, 9 months ago (2013-03-06 09:16:41 UTC) #2

Lasse Reichstein Nielsen

Adding VM and dart2js'ers as well for reviews of those parts.

7 years, 9 months ago (2013-03-06 11:05:08 UTC) #3

floitsch

LGTM. https://codereview.chromium.org/12441003/diff/1/sdk/lib/core/string.dart File sdk/lib/core/string.dart (right): https://codereview.chromium.org/12441003/diff/1/sdk/lib/core/string.dart#newcode142 sdk/lib/core/string.dart:142: */ use @deprecated. https://codereview.chromium.org/12441003/diff/1/tools/testing/dart/multitest.dart File tools/testing/dart/multitest.dart (right): https://codereview.chromium.org/12441003/diff/1/tools/testing/dart/multitest.dart#newcode125 ...

7 years, 9 months ago (2013-03-08 23:46:48 UTC) #6

Lasse Reichstein Nielsen

Committed patchset #2 manually as r19788 (presubmit successful).

7 years, 9 months ago (2013-03-11 12:59:40 UTC) #7

Lasse Reichstein Nielsen

7 years, 9 months ago (2013-03-12 11:43:12 UTC) #8

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/12441003/diff/1/tools/testing/dart/mul...
File tools/testing/dart/multitest.dart (right):

https://chromiumcodereview.appspot.com/12441003/diff/1/tools/testing/dart/mul...
tools/testing/dart/multitest.dart:125: tests[key] =
testsAsLines[key].join(line_separator) + line_separator;
Ack, will revert.
Apparently this isn't hit through normal testing.

Expand Messages | Collapse Messages