Properly collate multiple directory validation errors in scheduled_test.

Properly collate multiple directory validation errors in scheduled_test.

BUG=9266
Committed: https://code.google.com/p/dart/source/detail?r=20243

[Bob Nystrom, 2013-03-19 20:56:13]

Nits, but LGTM.

https://codereview.chromium.org/12440054/diff/1/pkg/scheduled_test/lib/src/de...
File pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart (right):

https://codereview.chromium.org/12440054/diff/1/pkg/scheduled_test/lib/src/de...
pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart:109: final
Collection<String> errors;
List?

https://codereview.chromium.org/12440054/diff/1/pkg/scheduled_test/lib/src/de...
pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart:111: static
_DirectoryValidationError merge(Iterable errors) {
How about a comment here like:

Flatten out nested directory validation errors.

[nweiz, 2013-03-19 21:03:33]

https://codereview.chromium.org/12440054/diff/1/pkg/scheduled_test/lib/src/de...
File pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart (right):

https://codereview.chromium.org/12440054/diff/1/pkg/scheduled_test/lib/src/de...
pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart:109: final
Collection<String> errors;
On 2013/03/19 20:56:13, Bob Nystrom wrote:
> List?

Why? We don't rely on any List-specific methods here, nor are we likely to.

https://codereview.chromium.org/12440054/diff/1/pkg/scheduled_test/lib/src/de...
pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart:111: static
_DirectoryValidationError merge(Iterable errors) {
On 2013/03/19 20:56:13, Bob Nystrom wrote:
> How about a comment here like:
> 
> Flatten out nested directory validation errors.

Done.

[nweiz, 2013-03-19 21:04:24]

Committed patchset #2 manually as r20243 (presubmit successful).