Issue 12440035: Support optional function expression parameters in dart2js... and dart2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12440035: Support optional function expression parameters in dart2js... and dart2dart. (Closed)

Created:
7 years, 9 months ago by aam-me

Modified:
7 years, 9 months ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Support optional function expression parameters in dart2js... and dart2dart. BUG=dartbug.com/4597 Committed: https://code.google.com/p/dart/source/detail?r=19849

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -13 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree_validator.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

aam-me

Hi, I'm picking up where https://chromiumcodereview.appspot.com/12751002 failed. I added three files to this new changelist: ...

7 years, 9 months ago (2013-03-12 03:19:28 UTC) #1

aam-me

7 years, 9 months ago (2013-03-12 11:10:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19849 (presubmit successful).