Issue 12440028: Skip analyzer-experimental/.../resolver_test test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12440028: Skip analyzer-experimental/.../resolver_test test. (Closed)

Created:
7 years, 9 months ago by scheglov

Modified:
7 years, 9 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Skip analyzer-experimental/.../resolver_test test. TBR R=efortuna@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19830

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	pkg/pkg.status	View		2 chunks	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 manually as r19830 (presubmit successful).

7 years, 9 months ago (2013-03-11 23:28:06 UTC) #2

Emily Fortuna

7 years, 9 months ago (2013-03-11 23:31:36 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/12440028/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/12440028/diff/1/pkg/pkg.status#newcode79
pkg/pkg.status:79: analyzer-experimental/test/generated/resolver_test: Skip
this line doesn't need to be added, because it passes on the command line (see
all the dart2js bots in the second column:
http://build.chromium.org/p/client.dart/console ) I suspect ast_test and
element_test can also be deleted (the limiting factory being they import
dart:io)

I think you should be able to delete lines 76, 77, and 79.

Expand Messages | Collapse Messages