Temporary map ArrayBuffer/ArrayBufferView to dynamic.

Temporary map ArrayBuffer/ArrayBufferView to dynamic.

For some amount of time we're going to allow both
DOM's and dart:typeddata implementations.

R=ager@google.com,blois@google.com,podivilov@chromium.org

Committed: https://code.google.com/p/dart/source/detail?r=19797

[Anton Muhin, 2013-03-11 14:41:56]

https://codereview.chromium.org/12440016/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/12440016/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:25373: +    if
((border_OR_canvas_OR_image_OR_pixels_OR_video is int ||
border_OR_canvas_OR_image_OR_pixels_OR_video == null) && ?pixels) {
looks pretty much like a bug in original code to me.

https://codereview.chromium.org/12440016/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:25428: +    if
((canvas_OR_format_OR_image_OR_pixels_OR_video is int ||
canvas_OR_format_OR_image_OR_pixels_OR_video == null) && ?pixels) {
ditto.

[Mads Ager (google), 2013-03-11 14:50:15]

LGTM

https://codereview.chromium.org/12440016/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/12440016/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:1802: +  dynamic
getRandomValues(/*ArrayBufferView*/ array) native;
Just curious: where is the /*ArrayBufferView*/ generated for this. You map the
type to dynamic in the codegenerator.

https://codereview.chromium.org/12440016/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:25373: +    if
((border_OR_canvas_OR_image_OR_pixels_OR_video is int ||
border_OR_canvas_OR_image_OR_pixels_OR_video == null) && ?pixels) {
On 2013/03/11 14:41:56, Anton Muhin wrote:
> looks pretty much like a bug in original code to me.

I agree, this looks pretty fishy. :-)

[Anton Muhin, 2013-03-11 15:01:05]

https://codereview.chromium.org/12440016/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/12440016/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:1802: +  dynamic
getRandomValues(/*ArrayBufferView*/ array) native;
On 2013/03/11 14:50:15, Mads Ager wrote:
> Just curious: where is the /*ArrayBufferView*/ generated for this. You map the
> type to dynamic in the codegenerator.

Take a look at TypeOrNothing helper:
https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/tool...

It used a lot in dart2js backend.

[Anton Muhin, 2013-03-11 15:20:07]

Committed patchset #1 manually as r19797 (presubmit successful).