Issue 12439005: Implement leaf runtime call stub on ARM and corresponding call redirection

Issue 12439005: Implement leaf runtime call stub on ARM and corresponding call redirection (Closed)

Created:
7 years, 9 months ago by regis

Modified:
7 years, 9 months ago

Reviewers:
zra, srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement leaf runtime call stub on ARM and corresponding call redirection in ARM simulator. Implement jump patching on ARM. Add missing ICache flush calls. Committed: https://code.google.com/p/dart/source/detail?r=19724

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -122 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_arm.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1 2	1 chunk	+12 lines, -1 line	0 comments	Download
M	runtime/vm/code_patcher.cc	View	1 2	1 chunk	+10 lines, -6 lines	0 comments	Download
M	runtime/vm/constants_arm.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/instructions_arm.h	View	1 2	2 chunks	+10 lines, -22 lines	0 comments	Download
M	runtime/vm/instructions_arm.cc	View	1 2	2 chunks	+32 lines, -13 lines	0 comments	Download
M	runtime/vm/instructions_arm_test.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
	runtime/vm/instructions_ia32.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/instructions_mips.h	View	1 2	1 chunk	+17 lines, -57 lines	0 comments	Download
M	runtime/vm/instructions_mips.cc	View	1 2	1 chunk	+21 lines, -13 lines	0 comments	Download
M	runtime/vm/instructions_x64.cc	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/runtime_entry_arm.cc	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/vm/simulator_arm.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1 2	4 chunks	+16 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_arm_test.cc	View	1 2	2 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/12439005/diff/7001/runtime/vm/instructions_arm.h File runtime/vm/instructions_arm.h (right): https://codereview.chromium.org/12439005/diff/7001/runtime/vm/instructions_arm.h#newcode40 runtime/vm/instructions_arm.h:40: static const int kLengthInBytes = 3*Instr::kInstrSize; Add space ...

7 years, 9 months ago (2013-03-08 19:47:04 UTC) #2

regis

Thanks! https://codereview.chromium.org/12439005/diff/7001/runtime/vm/instructions_arm.h File runtime/vm/instructions_arm.h (right): https://codereview.chromium.org/12439005/diff/7001/runtime/vm/instructions_arm.h#newcode40 runtime/vm/instructions_arm.h:40: static const int kLengthInBytes = 3*Instr::kInstrSize; On 2013/03/08 ...

7 years, 9 months ago (2013-03-08 21:15:37 UTC) #4

regis

7 years, 9 months ago (2013-03-08 21:16:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r19724 (presubmit successful).

Expand Messages | Collapse Messages