Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 12439002: Update idl files after Chrome roll. (Closed)

Created:
7 years, 9 months ago by Mads Ager (google)
Modified:
7 years, 9 months ago
Reviewers:
Anton Muhin, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update idl files after Chrome roll. Not much going on in this one. R=antonm@google.com,blois@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19464

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebCore/Modules/indexeddb/IDBRequest.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebCore/Modules/notifications/Notification.idl View 1 chunk +1 line, -1 line 2 comments Download
M third_party/WebCore/README View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebCore/bindings/scripts/test/TestObj.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebCore/inspector/Inspector.json View 5 chunks +8 lines, -16 lines 0 comments Download
M third_party/WebCore/inspector/compile-front-end.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebCore/page/DOMWindow.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (google)
7 years, 9 months ago (2013-03-05 11:46:17 UTC) #1
Anton Muhin
lgtm https://codereview.chromium.org/12439002/diff/1/third_party/WebCore/Modules/notifications/Notification.idl File third_party/WebCore/Modules/notifications/Notification.idl (right): https://codereview.chromium.org/12439002/diff/1/third_party/WebCore/Modules/notifications/Notification.idl#newcode54 third_party/WebCore/Modules/notifications/Notification.idl:54: [CallWith=ScriptExecutionContext] static void requestPermission(in [Optional, Callback] NotificationPermissionCallback callback); ...
7 years, 9 months ago (2013-03-05 11:47:41 UTC) #2
Mads Ager (google)
https://codereview.chromium.org/12439002/diff/1/third_party/WebCore/Modules/notifications/Notification.idl File third_party/WebCore/Modules/notifications/Notification.idl (right): https://codereview.chromium.org/12439002/diff/1/third_party/WebCore/Modules/notifications/Notification.idl#newcode54 third_party/WebCore/Modules/notifications/Notification.idl:54: [CallWith=ScriptExecutionContext] static void requestPermission(in [Optional, Callback] NotificationPermissionCallback callback); On ...
7 years, 9 months ago (2013-03-05 11:50:49 UTC) #3
Mads Ager (google)
Committed patchset #1 manually as r19464 (presubmit successful).
7 years, 9 months ago (2013-03-05 11:52:11 UTC) #4
blois
7 years, 9 months ago (2013-03-05 17:51:59 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698