Issue 12438003: dart:io | "Improve" raw_server_socket_cancel_test to not leave client sockets hanging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12438003: dart:io | "Improve" raw_server_socket_cancel_test to not leave client sockets hanging. (Closed)

Created:
7 years, 9 months ago by Bill Hesse

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | "Improve" raw_server_socket_cancel_test to not leave client sockets hanging. BUG=dartbug.com/8675 Committed: https://code.google.com/p/dart/source/detail?r=19466

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -17 lines)			Patch
	M	tests/standalone/io/raw_server_socket_cancel_test.dart	View		3 chunks	+45 lines, -16 lines	1 comment	Download
	M	tests/standalone/standalone.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

https://codereview.chromium.org/12438003/diff/1/tests/standalone/io/raw_server_socket_cancel_test.dart File tests/standalone/io/raw_server_socket_cancel_test.dart (right): https://codereview.chromium.org/12438003/diff/1/tests/standalone/io/raw_server_socket_cancel_test.dart#newcode75 tests/standalone/io/raw_server_socket_cancel_test.dart:75: socket.write([1,2,3]); We don't care if this write succeeds. I'll ...

7 years, 9 months ago (2013-03-05 11:52:43 UTC) #1

Bill Hesse

7 years, 9 months ago (2013-03-05 12:07:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19466 (presubmit successful).

Expand Messages | Collapse Messages