Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 12437022: Use scheduled_test for Pub tests. (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use scheduled_test for Pub tests. This was originally committed as r20250. Due to issue 9294, this failed on Windows. This commit works around that issue. BUG=8511 Committed: https://code.google.com/p/dart/source/detail?r=20264

Patch Set 1 #

Patch Set 2 : re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2011 lines, -2628 lines) Patch
M utils/pub/utils.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A utils/tests/pub/descriptor.dart View 1 chunk +178 lines, -0 lines 0 comments Download
A utils/tests/pub/descriptor/git.dart View 1 chunk +78 lines, -0 lines 0 comments Download
A utils/tests/pub/descriptor/tar.dart View 1 chunk +53 lines, -0 lines 0 comments Download
M utils/tests/pub/dev_dependency_test.dart View 1 chunk +53 lines, -52 lines 0 comments Download
M utils/tests/pub/install/broken_symlink_test.dart View 3 chunks +23 lines, -23 lines 0 comments Download
M utils/tests/pub/install/git/check_out_and_update_test.dart View 1 chunk +31 lines, -34 lines 0 comments Download
M utils/tests/pub/install/git/check_out_branch_test.dart View 1 chunk +15 lines, -14 lines 0 comments Download
M utils/tests/pub/install/git/check_out_revision_test.dart View 1 chunk +14 lines, -13 lines 0 comments Download
M utils/tests/pub/install/git/check_out_test.dart View 1 chunk +15 lines, -14 lines 0 comments Download
M utils/tests/pub/install/git/check_out_transitive_test.dart View 1 chunk +24 lines, -23 lines 0 comments Download
M utils/tests/pub/install/git/check_out_twice_test.dart View 1 chunk +17 lines, -19 lines 0 comments Download
M utils/tests/pub/install/git/check_out_with_trailing_slash_test.dart View 2 chunks +17 lines, -15 lines 0 comments Download
M utils/tests/pub/install/git/dependency_name_match_pubspec_test.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M utils/tests/pub/install/git/different_repo_name_test.dart View 2 chunks +12 lines, -11 lines 0 comments Download
M utils/tests/pub/install/git/lock_version_test.dart View 1 chunk +23 lines, -18 lines 0 comments Download
M utils/tests/pub/install/git/require_pubspec_name_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M utils/tests/pub/install/git/require_pubspec_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M utils/tests/pub/install/git/stay_locked_if_compatible_test.dart View 2 chunks +19 lines, -18 lines 0 comments Download
M utils/tests/pub/install/git/unlock_if_incompatible_test.dart View 2 chunks +19 lines, -18 lines 0 comments Download
M utils/tests/pub/install/hosted/do_not_update_on_removed_constraints_test.dart View 1 chunk +11 lines, -10 lines 0 comments Download
M utils/tests/pub/install/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M utils/tests/pub/install/hosted/fail_gracefully_on_url_resolve_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M utils/tests/pub/install/hosted/install_test.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M utils/tests/pub/install/hosted/install_transitive_test.dart View 1 chunk +8 lines, -7 lines 0 comments Download
M utils/tests/pub/install/hosted/remove_removed_dependency_test.dart View 1 chunk +9 lines, -8 lines 0 comments Download
M utils/tests/pub/install/hosted/remove_removed_transitive_dependency_test.dart View 1 chunk +13 lines, -12 lines 0 comments Download
M utils/tests/pub/install/hosted/repair_cache_test.dart View 1 chunk +22 lines, -23 lines 0 comments Download
M utils/tests/pub/install/hosted/resolve_constraints_test.dart View 1 chunk +11 lines, -10 lines 0 comments Download
M utils/tests/pub/install/hosted/stay_locked_if_compatible_test.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M utils/tests/pub/install/hosted/stay_locked_if_new_is_satisfied_test.dart View 1 chunk +14 lines, -13 lines 0 comments Download
M utils/tests/pub/install/hosted/stay_locked_test.dart View 1 chunk +11 lines, -6 lines 0 comments Download
M utils/tests/pub/install/hosted/unlock_if_incompatible_test.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M utils/tests/pub/install/hosted/unlock_if_new_is_unsatisfied_test.dart View 1 chunk +16 lines, -15 lines 0 comments Download
M utils/tests/pub/install/path/absolute_path_test.dart View 1 chunk +21 lines, -18 lines 0 comments Download
M utils/tests/pub/install/path/absolute_symlink_test.dart View 1 chunk +16 lines, -15 lines 0 comments Download
M utils/tests/pub/install/path/no_pubspec_test.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M utils/tests/pub/install/path/nonexistent_dir_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M utils/tests/pub/install/path/path_is_file_test.dart View 1 chunk +13 lines, -11 lines 0 comments Download
M utils/tests/pub/install/path/relative_path_test.dart View 1 chunk +32 lines, -31 lines 0 comments Download
M utils/tests/pub/install/path/relative_symlink_test.dart View 2 chunks +16 lines, -15 lines 0 comments Download
M utils/tests/pub/install/path/shared_dependency_symlink_test.dart View 2 chunks +25 lines, -24 lines 0 comments Download
M utils/tests/pub/install/path/shared_dependency_test.dart View 1 chunk +66 lines, -65 lines 0 comments Download
M utils/tests/pub/install/pub_install_test.dart View 5 chunks +115 lines, -113 lines 0 comments Download
M utils/tests/pub/install/relative_symlink_test.dart View 2 chunks +23 lines, -21 lines 0 comments Download
M utils/tests/pub/oauth2_test.dart View 7 chunks +68 lines, -59 lines 0 comments Download
M utils/tests/pub/pub_cache_test.dart View 2 chunks +22 lines, -16 lines 0 comments Download
M utils/tests/pub/pub_lish_test.dart View 7 chunks +160 lines, -150 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 3 chunks +9 lines, -7 lines 0 comments Download
M utils/tests/pub/pub_uploader_test.dart View 2 chunks +57 lines, -52 lines 0 comments Download
M utils/tests/pub/sdk_constraint_test.dart View 6 chunks +40 lines, -38 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 20 chunks +190 lines, -1244 lines 0 comments Download
M utils/tests/pub/update/git/do_not_update_if_unneeded_test.dart View 2 chunks +30 lines, -29 lines 0 comments Download
M utils/tests/pub/update/git/update_locked_test.dart View 1 chunk +30 lines, -29 lines 0 comments Download
M utils/tests/pub/update/git/update_one_locked_test.dart View 1 chunk +30 lines, -29 lines 0 comments Download
M utils/tests/pub/update/git/update_to_incompatible_pubspec_test.dart View 1 chunk +18 lines, -17 lines 0 comments Download
M utils/tests/pub/update/git/update_to_nonexistent_pubspec_test.dart View 1 chunk +16 lines, -15 lines 0 comments Download
M utils/tests/pub/update/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M utils/tests/pub/update/hosted/remove_removed_dependency_test.dart View 1 chunk +9 lines, -8 lines 0 comments Download
M utils/tests/pub/update/hosted/remove_removed_transitive_dependency_test.dart View 1 chunk +13 lines, -12 lines 0 comments Download
M utils/tests/pub/update/hosted/unlock_dependers_test.dart View 1 chunk +10 lines, -9 lines 0 comments Download
M utils/tests/pub/update/hosted/unlock_if_necessary_test.dart View 1 chunk +10 lines, -9 lines 0 comments Download
M utils/tests/pub/update/hosted/update_removed_constraints_test.dart View 1 chunk +11 lines, -10 lines 0 comments Download
M utils/tests/pub/update/pub_update_test.dart View 3 chunks +28 lines, -26 lines 0 comments Download
M utils/tests/pub/validator_test.dart View 15 chunks +136 lines, -128 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
The only difference from the previous CL is lines 353-356 in test_pub.dart.
7 years, 9 months ago (2013-03-20 00:27:22 UTC) #1
Bob Nystrom
LGTM!
7 years, 9 months ago (2013-03-20 00:50:38 UTC) #2
nweiz
7 years, 9 months ago (2013-03-20 00:51:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698