Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 12437017: dart:io | Make broken links report NOT_FOUND from FileSystemEntity.typeSync on Windows. (Closed)

Created:
7 years, 9 months ago by Bill Hesse
Modified:
7 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Make broken links report NOT_FOUND from FileSystemEntity.typeSync on Windows. BUG=dartbug.com/8935 Committed: https://code.google.com/p/dart/source/detail?r=20075

Patch Set 1 #

Patch Set 2 : Remove TODO comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M runtime/bin/file_win.cc View 1 1 chunk +24 lines, -6 lines 0 comments Download
M tests/standalone/io/windows_file_system_links_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 9 months ago (2013-03-14 17:07:32 UTC) #1
Søren Gjesse
lgtm
7 years, 9 months ago (2013-03-15 12:21:42 UTC) #2
Bill Hesse
7 years, 9 months ago (2013-03-15 12:57:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20075 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698