Infer SendSet node correctly.

Infer SendSet node correctly.
Committed: https://code.google.com/p/dart/source/detail?r=19470

[kasperl, 2013-03-05 09:56:25]

LGTM.

https://codereview.chromium.org/12434002/diff/4/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12434002/diff/4/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:841:
// TODO(ngeoffray): Tell that the index set was called.
Tell who? Are you going to just register something in the inferer? In that case,
maybe adding dummy methods for these things instead of sprinkling these comments
around?

   registerIndexSetUse
   registerSetterUse
   ...

[ngeoffray, 2013-03-05 11:59:05]

Thanks Kasper, PTAL. I have fixed a problem with prefix and postfix returned
type, and added a test.

https://codereview.chromium.org/12434002/diff/4/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12434002/diff/4/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:841:
// TODO(ngeoffray): Tell that the index set was called.
On 2013/03/05 09:56:25, kasperl wrote:
> Tell who? Are you going to just register something in the inferer? In that
case,
> maybe adding dummy methods for these things instead of sprinkling these
comments
> around?
> 
>    registerIndexSetUse
>    registerSetterUse
>    ...

Done.

[kasperl, 2013-03-05 12:26:49]

LGTM.

https://codereview.chromium.org/12434002/diff/11001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12434002/diff/11001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:940: 
The rest of the code doesn't have these newlines in there. Remove these for
consistency or add more in other places?

https://codereview.chromium.org/12434002/diff/11001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:988:
// Bogus SendSet, for example [:myMethod += 42 :].
Space after [:

[ngeoffray, 2013-03-05 12:34:46]

Thanks Kasper.

https://codereview.chromium.org/12434002/diff/11001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12434002/diff/11001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:940: 
On 2013/03/05 12:26:49, kasperl wrote:
> The rest of the code doesn't have these newlines in there. Remove these for
> consistency or add more in other places?

New lines removed.

https://codereview.chromium.org/12434002/diff/11001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:988:
// Bogus SendSet, for example [:myMethod += 42 :].
On 2013/03/05 12:26:49, kasperl wrote:
> Space after [:

Done.

[ngeoffray, 2013-03-05 12:38:24]

Committed patchset #8 manually as r19470 (presubmit successful).