Issue 1243293002: Convert a bunch of tests to use scheduled_test's infrastructure.

Issue 1243293002: Convert a bunch of tests to use scheduled_test's infrastructure. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Convert a bunch of tests to use scheduled_test's infrastructure. This makes the tests cleaner and more concise, as well as providing more information for debugging. This gets rid of the "does not preserve state" browser tests, because it turns out that they weren't actually doing anything anyway (otherwise IE would have failed, since it *does* preserve state). It also adds tests for every browser being able to run successful and failing tests. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/472805265165e7c66bb6eca810f00f7832aa82ea

Patch Set 1 #

Total comments: 6

Patch Set 2 : Code review changes #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1371 lines, -2002 lines)			Patch
M	pubspec.yaml	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	test/io.dart	View		3 chunks	+107 lines, -80 lines	0 comments	Download
M	test/runner/browser/chrome_test.dart	View		2 chunks	+52 lines, -115 lines	0 comments	Download
A	test/runner/browser/code_server.dart	View		1 chunk	+87 lines, -0 lines	0 comments	Download
M	test/runner/browser/compact_reporter_test.dart	View		2 chunks	+16 lines, -33 lines	0 comments	Download
M	test/runner/browser/content_shell_test.dart	View		2 chunks	+49 lines, -119 lines	0 comments	Download
M	test/runner/browser/dartium_test.dart	View		2 chunks	+30 lines, -136 lines	0 comments	Download
M	test/runner/browser/expanded_reporter_test.dart	View		1 chunk	+16 lines, -33 lines	0 comments	Download
M	test/runner/browser/firefox_test.dart	View		2 chunks	+30 lines, -147 lines	0 comments	Download
M	test/runner/browser/internet_explorer_test.dart	View		2 chunks	+49 lines, -73 lines	0 comments	Download
M	test/runner/browser/phantom_js_test.dart	View		2 chunks	+30 lines, -137 lines	0 comments	Download
M	test/runner/browser/runner_test.dart	View		22 chunks	+237 lines, -290 lines	0 comments	Download
M	test/runner/browser/safari_test.dart	View		2 chunks	+48 lines, -110 lines	0 comments	Download
M	test/runner/compact_reporter_test.dart	View		6 chunks	+29 lines, -35 lines	0 comments	Download
M	test/runner/expanded_reporter_test.dart	View	1	6 chunks	+26 lines, -32 lines	0 comments	Download
M	test/runner/pub_serve_test.dart	View		6 chunks	+151 lines, -197 lines	0 comments	Download
M	test/runner/runner_test.dart	View		18 chunks	+267 lines, -283 lines	0 comments	Download
M	test/runner/signal_test.dart	View		6 chunks	+86 lines, -115 lines	0 comments	Download
M	test/runner/test_on_test.dart	View		6 chunks	+56 lines, -66 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

a few questions and nits, but otherwise LGTM https://codereview.chromium.org/1243293002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1243293002/diff/1/pubspec.yaml#newcode3 pubspec.yaml:3: # ...

5 years, 5 months ago (2015-07-22 04:10:12 UTC) #2

nweiz

https://codereview.chromium.org/1243293002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1243293002/diff/1/pubspec.yaml#newcode3 pubspec.yaml:3: # This version should really be 0.12.1-dev, but scheduled_test ...

5 years, 5 months ago (2015-07-22 18:35:48 UTC) #4

nweiz

5 years, 5 months ago (2015-07-22 18:38:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
472805265165e7c66bb6eca810f00f7832aa82ea (presubmit successful).

Expand Messages | Collapse Messages