Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1243263003: Fix bad assert in constant evaluation. (Closed)

Created:
5 years, 5 months ago by rmacnak
Modified:
5 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/indirect_const_null_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 5 months ago (2015-07-22 21:08:15 UTC) #2
regis
lgtm
5 years, 5 months ago (2015-07-22 21:23:29 UTC) #3
rmacnak
5 years, 5 months ago (2015-07-22 21:25:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea65b867d35ebf1f9ab3951314813370204b80d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698