Issue 12431009: Add --analyze-signatures-only option to dart2js

Issue 12431009: Add --analyze-signatures-only option to dart2js (Closed)

Created:
7 years, 9 months ago by Johnni Winther

Modified:
7 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add --analyze-signatures-only option to dart2js Committed: https://code.google.com/p/dart/source/detail?r=19489

Patch Set 4 : Updated cf. comments + test expanded #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -3 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/apiimpl.dart	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2 3	3 chunks	+10 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart2js.dart	View	1 2 3	2 chunks	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/analyze_only_test.dart	View	1 2 3	2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/12431009/diff/2001/sdk/lib/_internal/compiler/implementation/apiimpl.dart File sdk/lib/_internal/compiler/implementation/apiimpl.dart (right): https://codereview.chromium.org/12431009/diff/2001/sdk/lib/_internal/compiler/implementation/apiimpl.dart#newcode64 sdk/lib/_internal/compiler/implementation/apiimpl.dart:64: if (analyzeSignaturesOnly && !analyzeOnly) { How about --analyze-signatures-only ...

7 years, 9 months ago (2013-03-05 14:32:59 UTC) #2

Johnni Winther

Committed patchset #4 manually as r19489 (presubmit successful).

7 years, 9 months ago (2013-03-05 16:52:06 UTC) #3

Johnni Winther

7 years, 9 months ago (2013-03-05 16:52:49 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12431009/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/apiimpl.dart (right):

https://codereview.chromium.org/12431009/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/apiimpl.dart:64: if
(analyzeSignaturesOnly && !analyzeOnly) {
On 2013/03/05 14:32:59, ahe wrote:
> How about --analyze-signatures-only implies --analyze-only?

Done.

https://codereview.chromium.org/12431009/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/dart2js.dart (right):

https://codereview.chromium.org/12431009/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart2js.dart:202: new
OptionHandler('--analyze-signatures-only', passThrough),
On 2013/03/05 14:32:59, ahe wrote:
> Document option.

Done.

Expand Messages | Collapse Messages