Issue 12431004: Implement subclass union and intersection on type mask.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12431004: Implement subclass union and intersection on type mask. (Closed)

Created:
7 years, 9 months ago by kasperl

Modified:
7 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement subclass union and intersection on type mask. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19468

Patch Set 2 : Fix typo. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -50 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	sdk/lib/_internal/compiler/implementation/types/type_mask.dart	View	1	5 chunks	+118 lines, -48 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/12431004/diff/1/sdk/lib/_internal/compiler/implementation/types/type_mask.dart File sdk/lib/_internal/compiler/implementation/types/type_mask.dart (right): https://codereview.chromium.org/12431004/diff/1/sdk/lib/_internal/compiler/implementation/types/type_mask.dart#newcode88 sdk/lib/_internal/compiler/implementation/types/type_mask.dart:88: return unionClass(other, compiler); unionClass -> unionSubclass

7 years, 9 months ago (2013-03-05 12:32:48 UTC) #2

kasperl

Committed patchset #2 manually as r19468 (presubmit successful).

7 years, 9 months ago (2013-03-05 12:34:40 UTC) #3

kasperl

7 years, 9 months ago (2013-03-05 12:35:32 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12431004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/type_mask.dart (right):

https://codereview.chromium.org/12431004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:88: return
unionClass(other, compiler);
On 2013/03/05 12:32:48, ngeoffray wrote:
> unionClass -> unionSubclass

Done.

Expand Messages | Collapse Messages

Issue 12431004: Implement subclass union and intersection on type mask. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix typo. #

Messages