Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 12431003: Fix issue 8848: access to type variable inside a closure declared in a field initializer must use t… (Closed)

Created:
7 years, 9 months ago by ngeoffray
Modified:
7 years, 9 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issue 8848: access to type variable inside a closure declared in a field initializer must use the parameter, and not the "this" object. Committed: https://code.google.com/p/dart/source/detail?r=19465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 9 months ago (2013-03-05 10:39:07 UTC) #1
kasperl
LGTM.
7 years, 9 months ago (2013-03-05 11:27:58 UTC) #2
ngeoffray
7 years, 9 months ago (2013-03-05 12:06:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19465 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698