Issue 1243063003: Get rid of ContextManager._contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1243063003: Get rid of ContextManager._contexts. (Closed)

Created:
5 years, 5 months ago by Paul Berry

Modified:
5 years, 5 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Get rid of ContextManager._contexts. This data structure was redundant with the tree of contexts maintained in ContextManager._rootInfo. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/37bf862fe4ac3997fdd593b08000263574a2c17d

Patch Set 2 : Fix typo. #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -48 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/context_manager.dart	View	1	15 chunks	+104 lines, -46 lines	0 comments	Download
M	pkg/analysis_server/test/context_manager_test.dart	View		2 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

LGTM https://codereview.chromium.org/1243063003/diff/1/pkg/analysis_server/test/context_manager_test.dart File pkg/analysis_server/test/context_manager_test.dart (right): https://codereview.chromium.org/1243063003/diff/1/pkg/analysis_server/test/context_manager_test.dart#newcode118 pkg/analysis_server/test/context_manager_test.dart:118: expect(contexts.length, 2); expect(context, hasLength(2));

5 years, 5 months ago (2015-07-23 17:58:41 UTC) #3

Paul Berry

5 years, 5 months ago (2015-07-23 18:03:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
37bf862fe4ac3997fdd593b08000263574a2c17d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1243063003: Get rid of ContextManager._contexts. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix typo. #

Messages