Issue 1243063002: dart2js cps: Remove NonTailThrow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1243063002: dart2js cps: Remove NonTailThrow. (Closed)

Created:
5 years, 5 months ago by asgerf

Modified:
5 years, 5 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Remove NonTailThrow. The builder instead creates a LetCont with an unused continuation to hold the unreachable code following the non-tail throw. This removes the cleanup pass after building and removes an awkward CPS node. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/c9733e22ced6aace91ab634cb70552ae54157a7c

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -94 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View	2 chunks	+0 lines, -47 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	3 chunks	+0 lines, -24 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 5 months ago (2015-07-21 09:07:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c9733e22ced6aace91ab634cb70552ae54157a7c (presubmit successful).