Issue 1242943010: Don't use "=>" for void methods in delegates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1242943010: Don't use "=>" for void methods in delegates. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
git@github.com:dart-lang/async.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't use "=>" for void methods in delegates. "=>" breaks if the delegate wraps a subclass that adds a return type (e.g. DelegatingSink wrapping a StreamSink). R=rnystrom@google.com Committed: https://github.com/dart-lang/async/commit/dda644888c90f39e79029450d8f3bcdb565ea0b0

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -9 lines)			Patch
M	lib/src/delegate/event_sink.dart	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	lib/src/delegate/sink.dart	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	lib/src/delegate/stream_sink.dart	View	1 chunk	+6 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

nweiz

5 years, 5 months ago (2015-07-23 18:10:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dda644888c90f39e79029450d8f3bcdb565ea0b0 (presubmit successful).