Issue 12428012: Properly handle errors from the OAuth2 token endpoint in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12428012: Properly handle errors from the OAuth2 token endpoint in pub. (Closed)

Created:
7 years, 9 months ago by nweiz

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom, Jennifer Messerly

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properly handle errors from the OAuth2 token endpoint in pub. This also adds more detailed HTTP logging to pub. BUG=8849 Committed: https://code.google.com/p/dart/source/detail?r=19734

Patch Set 1 #

Patch Set 2 : Minor changes #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -19 lines)			Patch
M	utils/pub/command_lish.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	utils/pub/http.dart	View	1	5 chunks	+69 lines, -6 lines	0 comments	Download
M	utils/pub/oauth2.dart	View		2 chunks	+14 lines, -13 lines	0 comments	Download
M	utils/tests/pub/oauth2_test.dart	View	1	2 chunks	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #2 manually as r19734 (presubmit successful).

7 years, 9 months ago (2013-03-08 21:57:36 UTC) #3

Bob Nystrom

7 years, 9 months ago (2013-03-12 18:40:27 UTC) #4

Message was sent while issue was closed.

This is great!

There are a few open pub bugs where users have reported deleting their
credentials "fixes" it. This looks like those should be actually fixed now. Can
you close those out too?

Expand Messages | Collapse Messages