Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 12428006: Add some Websocket tests. (Closed)

Created:
7 years, 9 months ago by Anders Johnsen
Modified:
7 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add some Websocket tests. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19462

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M tests/standalone/io/web_socket_test.dart View 1 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 9 months ago (2013-03-05 10:15:40 UTC) #1
Søren Gjesse
LGTM, thanks https://codereview.chromium.org/12428006/diff/1/tests/standalone/io/web_socket_test.dart File tests/standalone/io/web_socket_test.dart (right): https://codereview.chromium.org/12428006/diff/1/tests/standalone/io/web_socket_test.dart#newcode195 tests/standalone/io/web_socket_test.dart:195: webSocket.listen((_) { }, onDone: server.close); Expect no ...
7 years, 9 months ago (2013-03-05 11:21:37 UTC) #2
Anders Johnsen
Ty, landing. https://codereview.chromium.org/12428006/diff/1/tests/standalone/io/web_socket_test.dart File tests/standalone/io/web_socket_test.dart (right): https://codereview.chromium.org/12428006/diff/1/tests/standalone/io/web_socket_test.dart#newcode195 tests/standalone/io/web_socket_test.dart:195: webSocket.listen((_) { }, onDone: server.close); On 2013/03/05 ...
7 years, 9 months ago (2013-03-05 11:30:58 UTC) #3
Anders Johnsen
7 years, 9 months ago (2013-03-05 11:31:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698