Issue 12428003: Use type mask to figure out if we can constant fold boolify operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12428003: Use type mask to figure out if we can constant fold boolify operations. (Closed)

Created:
7 years, 9 months ago by kasperl

Modified:
7 years, 9 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use type mask to figure out if we can constant fold boolify operations. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19456

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		1 chunk	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

https://codereview.chromium.org/12428003/diff/1/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right): https://codereview.chromium.org/12428003/diff/1/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart#newcode187 sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:187: DartType booleanType = backend.jsBoolClass.computeType(compiler); You could use '.rawType' here. ...

7 years, 9 months ago (2013-03-05 09:29:21 UTC) #3

kasperl

7 years, 9 months ago (2013-03-05 09:53:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19456 (presubmit successful).

Expand Messages | Collapse Messages