Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1242223002: Concrete implementation of completion request (from new API) (Closed)

Created:
5 years, 5 months ago by Brian Wilkerson
Modified:
5 years, 5 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Concrete implementation of completion request (from new API) R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/78fb9729fa6525db1116598eb83803858bfd24fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
A pkg/analysis_server/lib/src/services/completion/completion_core.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/completion_dart.dart View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 5 months ago (2015-07-18 21:50:30 UTC) #2
danrubel
lgtm
5 years, 5 months ago (2015-07-18 23:00:15 UTC) #3
Brian Wilkerson
5 years, 5 months ago (2015-07-19 15:37:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
78fb9729fa6525db1116598eb83803858bfd24fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698