Issue 12421005: Attempting to fix IndexedDB test on IE10

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12421005: Attempting to fix IndexedDB test on IE10 (Closed)

Created:
7 years, 9 months ago by blois

Modified:
7 years, 9 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Attempting to fix IndexedDB test on IE10 Diff is a bit odd, but I just moved the supported check from indexedb_5_test to indexeddb_1_test, removed grouping from 5 and renamed the DB. Not sure exactly what is going on, but the test just started randomly failing on IE10, it appears that the db variable is null. We do have some wierd issues around individual config on IE, so I'm wondering if that's causing the issue. Trying to re-organize the test to avoid it. I cannot repro the issue locally. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19653

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -165 lines)			Patch
M	tests/html/html.status	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/html/indexeddb_1_test.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/html/indexeddb_5_test.dart	View	1 chunk	+151 lines, -159 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 9 months ago (2013-03-07 21:39:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19653 (presubmit successful).

Expand Messages | Collapse Messages