Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1241953008: Fix assertion in FunctionVisitor to account for unresolved types. (Closed)

Created:
5 years, 5 months ago by siva
Modified:
5 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix assertion in FunctionVisitor to account for unresolved types. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/69b8da5d86c30ff995187aaa1bc39558a5d9db87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/dart_api_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 5 months ago (2015-07-16 21:14:20 UTC) #2
rmacnak
lgtm
5 years, 5 months ago (2015-07-16 21:35:50 UTC) #3
siva
5 years, 5 months ago (2015-07-16 21:41:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69b8da5d86c30ff995187aaa1bc39558a5d9db87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698