Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 12419009: Fix build break in dart2js. The snapshot length was not accounting for the magic number. (Closed)

Created:
7 years, 9 months ago by siva
Modified:
7 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix build break in dart2js. The snapshot length was not accounting for the magic number. Committed: https://code.google.com/p/dart/source/detail?r=20342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
runtime/bin/dartutils.h View 1 chunk +3 lines, -1 line 0 comments Download
runtime/bin/dartutils.cc View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 9 months ago (2013-03-21 19:47:08 UTC) #1
Ivan Posva
LGTM -ip
7 years, 9 months ago (2013-03-21 19:49:21 UTC) #2
siva
7 years, 9 months ago (2013-03-21 19:49:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20342 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698