Async-step, first cut.

Async-step, first cut.

Also fix inclusion of internal variables from outer scopes in var descriptors.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/0979a7b23ec1a1c3d56342dd78dd3808802bd439

[rmacnak, 2015-07-15 16:32:49]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com, turnidge@google.com

[rmacnak, 2015-07-15 16:32:50]

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/debugger.dart:1135: if
(event.asyncContinuation != null) {
This was mostly for debugging. Not sure if it should be kept: it's pretty
low-level but it does provide feedback that it is currently possible to do an
async step.

[Cutch, 2015-07-15 17:04:23]

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/debugger.dart:1135: if
(event.asyncContinuation != null) {
On 2015/07/15 16:32:50, rmacnak wrote:
> This was mostly for debugging. Not sure if it should be kept: it's pretty
> low-level but it does provide feedback that it is currently possible to do an
> async step.

I'd rater have something more user friendly:

'Paused in async function. astep supported'.

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/async_continuation_test.dart (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/async_continuation_test.dart:68:
print(event.asyncContinuation);
test line numbers?

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/async_step_test.dart (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/async_step_test.dart:55: atLine(int line) {
Add a return type 'IsolateTest':

IsolateTest atLine(int line) ...

Move this to test_helper.dart

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/test_helper.dart (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/test_helper.dart:158: Future<Isolate>
hasStoppedAtBreakpoint(Isolate isolate) {
why remove async?
why switch from using await to using then()?

https://codereview.chromium.org/1241673003/diff/1/runtime/vm/scopes.cc
File runtime/vm/scopes.cc (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/vm/scopes.cc#newcod...
runtime/vm/scopes.cc:366: vars->Add(desc);
do you have a test that checks the var descriptor contents?

[rmacnak, 2015-07-16 19:42:17]

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/debugger.dart:1135: if
(event.asyncContinuation != null) {
On 2015/07/15 17:04:23, Cutch wrote:
> On 2015/07/15 16:32:50, rmacnak wrote:
> > This was mostly for debugging. Not sure if it should be kept: it's pretty
> > low-level but it does provide feedback that it is currently possible to do
an
> > async step.
> 
> I'd rater have something more user friendly:
> 
> 'Paused in async function. astep supported'.

Done.

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/async_continuation_test.dart (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/async_continuation_test.dart:68:
print(event.asyncContinuation);
On 2015/07/15 17:04:23, Cutch wrote:
> test line numbers?

Added

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/async_step_test.dart (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/async_step_test.dart:55: atLine(int line) {
On 2015/07/15 17:04:23, Cutch wrote:
> Add a return type 'IsolateTest':
> 
> IsolateTest atLine(int line) ...
> 
> Move this to test_helper.dart

Done.

https://codereview.chromium.org/1241673003/diff/1/runtime/vm/scopes.cc
File runtime/vm/scopes.cc (right):

https://codereview.chromium.org/1241673003/diff/1/runtime/vm/scopes.cc#newcod...
runtime/vm/scopes.cc:366: vars->Add(desc);
On 2015/07/15 17:04:23, Cutch wrote:
> do you have a test that checks the var descriptor contents?

Absence of internal names covered by async_scope_test. Presence of async
operation covered by async_continuation_test.

[Cutch, 2015-07-16 19:47:50]

LGTM with one naming suggestion

https://codereview.chromium.org/1241673003/diff/60001/runtime/observatory/tes...
File runtime/observatory/tests/service/test_helper.dart (right):

https://codereview.chromium.org/1241673003/diff/60001/runtime/observatory/tes...
runtime/observatory/tests/service/test_helper.dart:209: IsolateTest atLine(int
line) {
How about renaming this to stoppedAtLine?

[rmacnak, 2015-07-16 20:05:23]

https://codereview.chromium.org/1241673003/diff/60001/runtime/observatory/tes...
File runtime/observatory/tests/service/test_helper.dart (right):

https://codereview.chromium.org/1241673003/diff/60001/runtime/observatory/tes...
runtime/observatory/tests/service/test_helper.dart:209: IsolateTest atLine(int
line) {
On 2015/07/16 19:47:50, Cutch wrote:
> How about renaming this to stoppedAtLine?

Done.

[rmacnak, 2015-07-16 20:05:43]

Committed patchset #5 (id:80001) manually as
0979a7b23ec1a1c3d56342dd78dd3808802bd439 (presubmit successful).