Issue 12413005: Revert "Address code review comments on r19350"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12413005: Revert "Address code review comments on r19350" (Closed)

Created:
7 years, 9 months ago by sra1

Modified:
7 years, 9 months ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Address code review comments on r19350" Committed: https://code.google.com/p/dart/source/detail?r=19449

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		1 chunk	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

Committed patchset #1 manually as r19449 (presubmit successful).

7 years, 9 months ago (2013-03-05 07:11:54 UTC) #1

ngeoffray

On 2013/03/05 07:11:54, sra1 wrote: > Committed patchset #1 manually as r19449 (presubmit successful). What ...

7 years, 9 months ago (2013-03-05 07:44:32 UTC) #2

sra1

7 years, 9 months ago (2013-03-05 07:47:06 UTC) #3

Message was sent while issue was closed.

On 2013/03/05 07:44:32, ngeoffray wrote:
> On 2013/03/05 07:11:54, sra1 wrote:
> > Committed patchset #1 manually as r19449 (presubmit successful).
> 
> What went wrong?

Chromium infrastructure. It is nothing to do with this CL but that is obvious
now to anyone who looks.

Expand Messages | Collapse Messages