Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1241193002: Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight. (Closed)

Created:
5 years, 5 months ago by scheglov
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/55cb93b422559d847aa1626e1d22ff1b88e05799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1279 lines, -184 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +148 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 6 chunks +19 lines, -13 lines 0 comments Download
A + pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 13 chunks +84 lines, -38 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 9 chunks +323 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +12 lines, -0 lines 0 comments Download
A + pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 11 chunks +158 lines, -92 lines 0 comments Download
M pkg/analysis_server/test/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A + pkg/analysis_server/test/integration/analysis/highlights_test2.dart View 5 chunks +26 lines, -18 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 5 chunks +14 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 6 chunks +71 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/HighlightRegionType.java View 2 chunks +217 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +196 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 5 months ago (2015-07-20 16:59:04 UTC) #1
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-20 17:21:49 UTC) #2
scheglov
5 years, 5 months ago (2015-07-20 17:37:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55cb93b422559d847aa1626e1d22ff1b88e05799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698